feat(ec2): dry run connection script to surface errors earlier. #6037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
justinmk3
reviewed
Nov 16, 2024
justinmk3
reviewed
Nov 16, 2024
justinmk3
reviewed
Nov 16, 2024
justinmk3
reviewed
Nov 16, 2024
Co-authored-by: Justin M. Keyes <[email protected]>
Hweinstock
changed the title
justinmk3
reviewed
Dec 3, 2024
justinmk3
reviewed
Dec 3, 2024
justinmk3
approved these changes
Dec 3, 2024
Co-authored-by: Justin M. Keyes <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…6037) ## Problem Follow up to aws#6018 (comment) ## Solution - Run `ssh` within the same env as it will be run on real connection. - Log any resulting errors, and inform user where the process failed. - Also part of this PR is moving some functions to `remoteSession.ts` that are general enough to be there. Error msg: <img width="1518" alt="Screenshot 2024-11-15 at 5 53 51 PM" src="https://github.com/user-attachments/assets/e8e56887-b792-43e3-9d94-73d0e5246766"> --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up to #6018 (comment)
Solution
sshwithin the same env as it will be run on real connection.remoteSession.tsthat are general enough to be there.Error msg:
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.